Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Service #1525

Merged
merged 5 commits into from
May 24, 2024
Merged

Metrics Service #1525

merged 5 commits into from
May 24, 2024

Conversation

pflopez
Copy link
Contributor

@pflopez pflopez commented May 22, 2024

Removes usages of conditions/metric endpoint, using /conditions/config/?flat=true instead.
The result of this is saved by region to avoid subsequent requests.

@pflopez pflopez changed the title Metrics service wipMetrics service May 22, 2024
@pflopez pflopez changed the title wipMetrics service wip Metrics service May 22, 2024
@pflopez pflopez force-pushed the metrics-service branch 2 times, most recently from 6e8a340 to 2eee7ba Compare May 22, 2024 18:16
@pflopez pflopez force-pushed the metrics-service branch from 2eee7ba to e78ce1c Compare May 22, 2024 18:24
@pflopez pflopez changed the title wip Metrics service Metrics Service May 22, 2024
@pflopez pflopez requested a review from lastminutediorama May 22, 2024 18:39
@pflopez pflopez marked this pull request as ready for review May 22, 2024 18:39
* Only fetches the metrics if we dont have a record already
* @param region
*/
public getMetricsForRegion(region: Region) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pflopez pflopez merged commit e4133d7 into main May 24, 2024
6 checks passed
@pflopez pflopez deleted the metrics-service branch May 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants